-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move argon2 to first, average, worst scoring. #24
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1999,27 +1999,29 @@ const testPlans = [ | |
{ | ||
name: "argon2-wasm", | ||
files: [ | ||
"./wasm/argon2-bundle.js", | ||
"./wasm/argon2.js", | ||
"./wasm/argon2-benchmark.js" | ||
"./wasm/argon2/argon2-bundle.js", | ||
"./wasm/argon2/argon2.js", | ||
"./wasm/argon2/benchmark.js" | ||
], | ||
preload: { | ||
argon2WasmBlob: "./wasm/argon2.wasm", | ||
argon2WasmBlob: "./wasm/argon2/argon2.wasm", | ||
}, | ||
benchmarkClass: WasmLegacyBenchmark, | ||
benchmarkClass: WasmEMCCBenchmark, | ||
iterations: 15, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Even with only 15 iterations, the non-SIMD variant runs quite long (>1 minute), while the SIMD variant runs ~2-3s with the same number of iterations. I am bit surprised by that stark difference (30x or more), so I will spend a brief time trying to understand why we are that slow. We do expect the SIMD and non-SIMD variant to do essentially the same amount of work, right? |
||
worstCaseCount: 2, | ||
testGroup: WasmGroup | ||
}, | ||
{ | ||
name: "argon2-wasm-simd", | ||
files: [ | ||
"./wasm/argon2-bundle.js", | ||
"./wasm/argon2.js", | ||
"./wasm/argon2-benchmark.js" | ||
"./wasm/argon2/argon2-bundle.js", | ||
"./wasm/argon2/argon2.js", | ||
"./wasm/argon2/benchmark.js" | ||
], | ||
preload: { | ||
argon2WasmSimdBlob: "./wasm/argon2-simd.wasm", | ||
argon2WasmSimdBlob: "./wasm/argon2/argon2-simd.wasm", | ||
}, | ||
benchmarkClass: WasmLegacyBenchmark, | ||
benchmarkClass: WasmEMCCBenchmark, | ||
testGroup: WasmGroup | ||
}, | ||
// WorkerTests | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar to the other Emscripten-built line items, could we move the generated files in a
build/
subdirectory, to distinguish them from manually written code, such asbenchmark.js
(just so we/someone in the future doesn't end up mixing/interjecting manually written with generated code again).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, is it correct that both
benchmark.js
andargon2.js
were written by you (or your colleagues)?