Move tfjs to first, average, worst scoring.#23
Merged
Conversation
Since this test is relatively slow per iteration I reduced the iteration counts to: non-simd: 15 iterations with worst 2. simd: 80 iterations with worst 4 (default). Also, I moved all the benchmark files to a tfjs directory to help organize the wasm directory a bit.
Contributor
|
Overall this looks good to me, with some high-level comments though:
|
Contributor
Author
|
r.e. your comments:
|
This makes the runtime for the benchmark ~7s/9s/11s for jsc/v8/sm respectively on my M4 Max MBP.
Contributor
|
Contributor
Author
|
Ok sounds like we have a plan. Gonna merge for now. |
kmiller68
added a commit
that referenced
this pull request
Jan 21, 2025
Revert "Merge pull request #23 from WebKit/tfjs-to-js-scoring"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since this test is relatively slow per iteration I reduced the iteration counts to: non-simd: 15 iterations with worst 2.
simd: 80 iterations with worst 4 (default).
Also, I moved all the benchmark files to a tfjs directory to help organize the wasm directory a bit.