Store times and scores explicitly #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's the goal here? I think I'm missing some context. |
|
I want to make the units explicit and make sure we have time+score everywhere available for consistency. Preparing this should make it a bit easier in the future whether we want to switch to times and only have a global score or not. |
kmiller68
reviewed
Dec 9, 2024
| summaryElement.onclick = displayCategoryScores; | ||
| if (showScoreDetails) | ||
| displayCategoryScores(); | ||
| statusElement.innerHTML = ''; | ||
| } else if (!dumpJSONResults) { | ||
| console.log("\n"); | ||
| for (let [category, scores] of categoryScores) | ||
| console.log(`${category}: ${uiFriendlyNumber(geomean(scores))}`); | ||
| console.log(`${category}: ${uiFriendlyScore(geomean(scores))}`); |
There was a problem hiding this comment.
e.g. can we do ${category}: ${uiFriendlyScore(geomean(scores))}, ${uiFriendlyDuration(geomean(times))}?
There was a problem hiding this comment.
I guess we can do this in a follow up PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepare the benchmarks for more flexible result calculation and visualisations: