Draft a prototype stdio design for wasip3. #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /// This function reads at most `amount` bytes from a | ||
| /// “standard input” source. | ||
| @since(version = 0.3.0) | ||
| read: func(amount: u32) -> result<list<u8>, error>; |
There was a problem hiding this comment.
shouldn't this be async so you can avoid blocking?
There was a problem hiding this comment.
Async in Wit is just a hint, so you can avoid blocking either way, and the main question is what the default should be.
In my experience most programs that use stdin use it in a synchronous way, which suggests making it sync by default, but I don't have a strong opinion about it.
There was a problem hiding this comment.
many C programs use functions like kbhit or O_NONBLOCK on stdin, imo we should have support in the C library for stuff like that, afaict that requires the C library to use the async version even if most programs just block.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are still some FIXME comments in the code to resolve.