Push struct.new down to make it more likely that heap stores can be optimized.
#6584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gkdn Reproed the case with the string constructor that had some inline code that prevented the |
kripken
reviewed
May 13, 2024
kripken
reviewed
May 14, 2024
kripken
reviewed
May 15, 2024
src/passes/OptimizeInstructions.cpp
Outdated
Comment on lines
1942
to
1944
| auto* tmp = list[i]; | ||
| list[i] = list[j]; | ||
| list[j] = tmp; |
There was a problem hiding this comment.
Suggested change
| auto* tmp = list[i]; | |
| list[i] = list[j]; | |
| list[j] = tmp; | |
| std::swap(list[i], list[j]); |
kripken
reviewed
May 21, 2024
| @@ -1,5 +1,5 @@ | |||
| ;; NOTE: Assertions have been generated by update_lit_checks.py and should not be edited. | |||
| ;; RUN: wasm-opt %s --remove-unused-names --optimize-instructions -all -S -o - \ | |||
| ;; RUN: wasm-opt %s --remove-unused-names --optimize-instructions -all -S -o - \ | |||
There was a problem hiding this comment.
unneeded space?
Suggested change
| ;; RUN: wasm-opt %s --remove-unused-names --optimize-instructions -all -S -o - \ | |
| ;; RUN: wasm-opt %s --remove-unused-names --optimize-instructions -all -S -o - \ |
| (nop) | ||
| ;; |
There was a problem hiding this comment.
Suggested change
| ;; | |
| ;; We do not swap with another local.set of struct.new. |
kripken
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heap stores (
struct.set) are optimized into thestruct.newwhen they are adjacent in a statement list.Pushing
struct.newdown when they are not adjacent increases the likelihood for heap stores to be optimized. Optimizing heap stores is a beneficial step in making struct fields immutable which in turn helps other various optimziations.