Repository navigation
Specify the RFC 9110 field-name syntax in wasi-http - #967
Closed
sainimal1ba-hue wants to merge 1 commit into
Closed
sainimal1ba-hue wants to merge 1 commit into
sainimal1ba-hue wants to merge 1 commit into
Conversation
The field-name docs left it unstated what syntax a field name follows. State that RFC 9110 defines it and allows only ASCII characters, and refer to it as the ground truth for what should be accepted as a field name, as asked for in the wasi-http champions triage of WebAssembly#786.
Contributor
|
I'm not inclined to review contributions from a first-time contributor to WebAssembly who doesn't have any other history related to Wasm in their profile. This is work I expect to be done by a human, not by an LLM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #786.
The field-name docs said field names are strings compared case-insensitively, but never said what syntax a field name has. This adds a paragraph pointing at RFC 9110 as the ground truth for what should be accepted as a field name: the field-name = token production (section 5.1), which allows only ASCII characters.
service.md and middleware.md are regenerated with wit-bindgen markdown --html-in-md --all-features (wit-bindgen 0.48.1, the version the release workflow pins).
Validation: WIT_FILES=["proposals/http/wit/types.wit"] node .github/scripts/validate-proposals.js passes: wit-deps lock check, WIT parse, wasm encoding, Component Model feature validation, @SInCE annotations.