Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add xdebug profiling support #100

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add xdebug profiling support #100

wants to merge 1 commit into from

Conversation

mikeymike
Copy link
Contributor

Adds support for profiling.

Unable to test compile due to a bunch of I think unrelated errors.

Also this relies on new PHP image builds

@shakyShane
Copy link
Contributor

@mikeymike do you mean errors in the PHP builds, because the builds here look good

@mikeymike
Copy link
Contributor Author

Nah my local builds... I need to sort out my Rust installation again

@shakyShane
Copy link
Contributor

@mikeymike so this is ready to go? not sure if anythings else is needed etc

@mikeymike
Copy link
Contributor Author

I think it's ready, images have been released a while back now 😄

@shakyShane
Copy link
Contributor

@mikeymike have you considered how this interacts with ‘wf2 xdebug enable’ etc? Or perhaps it has no effect?

@mikeymike
Copy link
Contributor Author

That's a good point, I didn't really look at the implementation details around that now you mention it.

This updates the NGINX though so maybe it does?

@mikeymike
Copy link
Contributor Author

So I just had a look at the implementation of xdebug enable/disable and I they're compatible.

This PR introduces a map to choose debug or non debug upstreams.
The current xdebug enable command keeps the same upstream keys but changes where they go so they're both pointed to php-debug.

So in the event of running xdebug enable regardless of where the map decides the upstream is we'll still always end up in the debug container anyway which is the intended result.

tldr looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants