Address several issues with reading specially crafted .NET metadata #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a couple of issues with reading specially crafted files that abuse implementation quirks of the CLR metadata reader.
The following quirks were addressed (sample files can be found in the PR):
#Schemastream forces the parsing of metadata as if it was EnC metadata even if the tablees stream name suggests compressed metadata.#Blob,#US,#Strings,#GUIDas compared to byte for byte compare when reading compressed metadata.#JTDand if it found it forces all column index sizes to 4 bytes.All the above-mentioned quirks were addressed in the PR and have accompanying tests.