Drop unused dependencies and most test data from published crates #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reduces the download size for the rqrr crate from crates.io from almost 3 MB to about 40 kB (1-2% of the current size). The "criterion" dependency is currently unused since all code in benches/* is commented out, so this comments out the criterion dependency too since it just adds compilation time for dozens of crates that are unused.
|
Thank you! |
|
Thank you for the short RTT :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working on packaging this crate for Fedora Linux as a new dependency of GNOME Snapshot.
During review we found that there is a lot of both large and potentially (though not necessarily!) problematic test images included in published crates.
Hopefully these changes make sense:
This reduces the download size for the rqrr crate from crates.io from almost 3 MB to about 40 kB (1-2% of the current size).
The "criterion" dependency is currently unused since all code in benches/* is commented out, so this comments out the criterion dependency too since it just adds compilation time for dozens of crates that are unused.