feat: Generic EngineTypes.RequestParams #3415
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When creating session request payload, it would be nice to let the developer create strongly typed
RequestParams
. This can easily be done be converting the existingEngineTypes.RequestParams
to a TypeScript generic, with a default type parameter value ofany
. The default value makes the type parameter optional so that any existing usage of the type will not change, but gives the developer the option to add more specific params types if they want to.Type of change
How has this been tested?
Ran the build command in the root repo successfully.
Examples/Screenshots (Optional)
Checklist
Additional Information (Optional)
For reference, I wanted to have a "TypedRequestParams" type when adding the Hedera example to the web-examples/dapps/react-dapp-v2, and this is how that can be accomplished with the fixed
EngineTypes.RequestParams
as a base type. Definitely not as readable/friendly as making that type generic: