Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: random session identifier #2454

Merged
merged 9 commits into from
Jun 19, 2024
Merged

feat: random session identifier #2454

merged 9 commits into from
Jun 19, 2024

Conversation

ganchoradkov
Copy link
Member

@ganchoradkov ganchoradkov commented May 23, 2023 •
edited
Loading

Description

Added randomSessionIdentifier as per spec WalletConnect/walletconnect-specs#125

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Draft PR (breaking/non-breaking change which needs more work for having a proper functionality [Mark this PR as ready to review only when completely ready])
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How has this been tested?

dogfooding
tests

Checklist

  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Additional Information (Optional)

Please include any additional information that may be useful for the reviewer.

@arein arein added the accepted label May 23, 2023
@ganchoradkov ganchoradkov self-assigned this May 23, 2023
@JonathanConn
Copy link
Contributor

Hey guys, could one of you close this for me plz 🙏

Miss you all, hope you are doing well <3

@ganchoradkov @ignaciosantise @Cali93

Cali93
Cali93 approved these changes Jun 19, 2024
View reviewed changes
Copy link
Contributor

@Cali93 Cali93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, short and sweet 👌

@ganchoradkov ganchoradkov merged commit 5899f27 into v2.0 Jun 19, 2024
9 checks passed
@ganchoradkov ganchoradkov deleted the feat/random-session-identifier branch June 19, 2024 15:43
@ganchoradkov ganchoradkov mentioned this pull request Jul 17, 2024
Merged
20 tasks
github-merge-queue bot referenced this pull request in valora-inc/wallet Aug 13, 2024
@renovate
fix(deps): update dependency @walletconnect/react-native-compat to ^2…
a400664 
….14.0 (#5765)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[@walletconnect/react-native-compat](https://togithub.com/walletconnect/walletconnect-monorepo)
| [`^2.13.3` ->
`^2.14.0`](https://renovatebot.com/diffs/npm/@walletconnect%2freact-native-compat/2.13.3/2.14.0)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/@walletconnect%2freact-native-compat/2.14.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@walletconnect%2freact-native-compat/2.14.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@walletconnect%2freact-native-compat/2.13.3/2.14.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@walletconnect%2freact-native-compat/2.13.3/2.14.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>walletconnect/walletconnect-monorepo
(@&#8203;walletconnect/react-native-compat)</summary>

###
[`v2.14.0`](https://togithub.com/WalletConnect/walletconnect-monorepo/releases/tag/2.14.0)

[Compare
Source](https://togithub.com/walletconnect/walletconnect-monorepo/compare/2.13.3...2.14.0)

##### What's Changed

- fix: update requester and responder pairing metadata upon
sessionAuthenticate approval by
[@&#8203;quetool](https://togithub.com/quetool) in
[https://github.com/WalletConnect/walletconnect-monorepo/pull/4614](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/4614)
- feat: random session identifier by
[@&#8203;ganchoradkov](https://togithub.com/ganchoradkov) in
[https://github.com/WalletConnect/walletconnect-monorepo/pull/2454](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/2454)
- fix: process incoming requests in order by
[@&#8203;ganchoradkov](https://togithub.com/ganchoradkov) in
[https://github.com/WalletConnect/walletconnect-monorepo/pull/4638](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/4638)
- chore: parsing optional fields in formatMessage function by
[@&#8203;ignaciosantise](https://togithub.com/ignaciosantise) in
[https://github.com/WalletConnect/walletconnect-monorepo/pull/5114](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/5114)
- fix: always use fallback verify server by
[@&#8203;chris13524](https://togithub.com/chris13524) in
[https://github.com/WalletConnect/walletconnect-monorepo/pull/5091](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/5091)
- refactor: `.org` relay url by
[@&#8203;ganchoradkov](https://togithub.com/ganchoradkov) in
[https://github.com/WalletConnect/walletconnect-monorepo/pull/5151](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/5151)
- feat: generic provider by
[@&#8203;ganchoradkov](https://togithub.com/ganchoradkov) in
[https://github.com/WalletConnect/walletconnect-monorepo/pull/5182](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/5182)
- feat: verify context session authenticate by
[@&#8203;ganchoradkov](https://togithub.com/ganchoradkov) in
[https://github.com/WalletConnect/walletconnect-monorepo/pull/5192](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/5192)
- refactor: reduce reconnect timeout by
[@&#8203;ganchoradkov](https://togithub.com/ganchoradkov) in
[https://github.com/WalletConnect/walletconnect-monorepo/pull/5194](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/5194)

##### New Contributors

- [@&#8203;quetool](https://togithub.com/quetool) made their first
contribution in
[https://github.com/WalletConnect/walletconnect-monorepo/pull/4614](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/4614)

**Full Changelog**:
WalletConnect/walletconnect-monorepo@2.13.3...2.14.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone
America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone
America/Los_Angeles.

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View the
[repository job
log](https://developer.mend.io/github/valora-inc/wallet).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yMC4xIiwidXBkYXRlZEluVmVyIjoiMzguMjAuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsibnBtIiwicmVub3ZhdGUiXX0=-->

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: valora-bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ignaciosantise ignaciosantise ignaciosantise approved these changes

@Cali93 Cali93 Cali93 approved these changes

@JonathanConn JonathanConn JonathanConn approved these changes

Assignees

@ganchoradkov ganchoradkov

Labels
accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ganchoradkov @JonathanConn @ignaciosantise @Cali93 @arein