Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: swiper item width when there is less than x items #2535

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Leiksa
Copy link
Contributor

@Leiksa Leiksa commented Sep 4, 2024

What expected:
Screenshot 2024-09-04 at 10 55 50

Issue:
Screenshot 2024-09-04 at 10 18 54
Screenshot 2024-09-04 at 10 19 02

@Leiksa Leiksa requested a review from a team as a code owner September 4, 2024 08:56
Copy link

github-actions bot commented Sep 4, 2024

👀 Visit Preview

Comment on lines 117 to +118
min-width: ${getSlideWidth(mobile, spaceBetween, theme.toRem)};
max-width: ${getSlideWidth(mobile, spaceBetween, theme.toRem)};
Copy link
Contributor

@theo-mesnil theo-mesnil Sep 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hum du coup possiblement un width ferait l'affaire ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, css est un peu chelou sur ce point. Ça fonctionne uniquement en utilisant max/min width 🤷🏼‍♀️

Copy link
Contributor

@theo-mesnil theo-mesnil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Leiksa je te laisse rebase :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants