chore: allow shape prop to use object notation with breakpoints as keys #2455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
P1X3L
force-pushed
the
chore-upgrade-button-shape-prop
branch
4 times, most recently
from
4ebda81
to
818b4e6
Compare
Signed-off-by: Paul-Xavier Ceccaldi <[email protected]>
P1X3L
force-pushed
the
chore-upgrade-button-shape-prop
branch
from
818b4e6
to
318b7f5
Compare
|
From my point of view, this code adds a lot of complexity for a very small use case (especially since we maybe want to remove the "shape" prop in the future?) I like to keep WUI as simple as possible 🤷🏻♂️ |
|
Ok, I see your point, I'll make the changes where I found them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid Cumulative Layout Shift, we have spotted that we could leverage the usage of the object notation on Button's
shapeprop (like we do on style props)(more info here 👉 https://www.debugbear.com/project/865/pageLoad/6293/overview?metric=cumulativeLayoutShift focus on the share button)
Until now, button's
shapeattribute had the type'circle' | squareIt can now be
circle | square | default | Record<BREAKPOINT KEYS HERE, ('circle' | 'square' | 'default')>We have an app using
Buttonwith theshapeprop being dynamically set with JS tocircledepending on breakpoints.Unfortunately, these dynamic styles are not working on SSR so it is better to use css to do so.