Fix: check and use parents scale css for tabs underline position #2178

Isaacmaamouche · 2023-08-08T15:25:21Z

Fixes #2177

Enregistrement.de.l.ecran.2023-08-08.a.16.33.47.mov

github-actions · 2023-08-08T15:25:34Z

packages/Tabs/src/utils.ts

Isaacmaamouche added 3 commits August 8, 2023 16:31

fix: check and use parents scale css

36c01fa

fix: move refs access back in useEffect

6156823

fix: handle NaN value

b71b181

Isaacmaamouche requested a review from a team as a code owner August 8, 2023 15:25

github-actions bot added the to-review label Aug 8, 2023

theo-mesnil reviewed Aug 10, 2023

View reviewed changes

packages/Tabs/src/utils.ts Show resolved Hide resolved

fix: check if window is defined for ssr

33408c0

Isaacmaamouche requested a review from a team August 22, 2023 08:44

theo-mesnil approved these changes Aug 22, 2023

View reviewed changes

github-actions bot added approved and removed to-review labels Aug 22, 2023

Isaacmaamouche added this pull request to the merge queue Aug 24, 2023

Merged via the queue into master with commit b57cacb Aug 24, 2023
11 checks passed

Isaacmaamouche deleted the 2177-fix-tabs-underline-scaling branch August 24, 2023 14:11

Provide feedback