Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate from reakit to ariakit #2101

Merged
merged 57 commits into from
Aug 3, 2023
Merged

Conversation

theo-mesnil
Copy link
Contributor

Fixes #2099

@theo-mesnil theo-mesnil added this to the Version 5 RC milestone Jun 21, 2023
@theo-mesnil theo-mesnil self-assigned this Jun 21, 2023
@github-actions github-actions bot added the wip label Jun 21, 2023
@github-actions
Copy link

👀 Visit Preview

@theo-mesnil theo-mesnil changed the title Feat migrate ariakit feat: migrate from reakit to ariakit Jun 21, 2023
@theo-mesnil theo-mesnil force-pushed the feat-migrate-ariakit branch 8 times, most recently from f69d6de to 56d15bb Compare July 24, 2023 17:56
@theo-mesnil theo-mesnil marked this pull request as ready for review July 27, 2023 15:29
@theo-mesnil theo-mesnil requested a review from a team as a code owner July 27, 2023 15:29
@theo-mesnil theo-mesnil added to-review and removed wip labels Jul 27, 2023
Copy link
Contributor

@liv7c liv7c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bravo pour la migration 🔥
J'ai juste mis quelques commentaires côté doc (quelques petites typos and co.)

docs/pages/components/drawer.mdx Outdated Show resolved Hide resolved
docs/pages/components/drawer.mdx Outdated Show resolved Hide resolved
docs/pages/components/emoji-picker.mdx Outdated Show resolved Hide resolved
docs/pages/components/emoji-picker.mdx Outdated Show resolved Hide resolved
docs/pages/components/emoji-picker.mdx Outdated Show resolved Hide resolved
docs/pages/upgrade.mdx Outdated Show resolved Hide resolved
docs/pages/upgrade.mdx Outdated Show resolved Hide resolved
docs/pages/upgrade.mdx Outdated Show resolved Hide resolved
docs/pages/upgrade.mdx Outdated Show resolved Hide resolved
docs/pages/upgrade.mdx Outdated Show resolved Hide resolved
Copy link
Contributor

@simon-hv simon-hv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gros GG 👏

docs/pages/upgrades/v4.mdx Outdated Show resolved Hide resolved
packages/Modal/src/styles.ts Outdated Show resolved Hide resolved
packages/RadioGroup/src/index.tsx Outdated Show resolved Hide resolved
theo-mesnil and others added 21 commits August 2, 2023 14:41
Co-authored-by: Olivia Coumans <[email protected]>
Co-authored-by: Olivia Coumans <[email protected]>
Co-authored-by: Olivia Coumans <[email protected]>
Co-authored-by: Olivia Coumans <[email protected]>
Co-authored-by: Olivia Coumans <[email protected]>
Co-authored-by: Olivia Coumans <[email protected]>
Co-authored-by: Olivia Coumans <[email protected]>
Co-authored-by: Olivia Coumans <[email protected]>
Co-authored-by: Olivia Coumans <[email protected]>
Co-authored-by: Olivia Coumans <[email protected]>
Co-authored-by: Olivia Coumans <[email protected]>
Co-authored-by: Olivia Coumans <[email protected]>
Co-authored-by: Olivia Coumans <[email protected]>
Co-authored-by: Olivia Coumans <[email protected]>
Co-authored-by: Olivia Coumans <[email protected]>
Co-authored-by: Olivia Coumans <[email protected]>
Co-authored-by: Olivia Coumans <[email protected]>
Co-authored-by: Olivia Coumans <[email protected]>
Co-authored-by: Olivia Coumans <[email protected]>
@theo-mesnil theo-mesnil added this pull request to the merge queue Aug 3, 2023
@theo-mesnil theo-mesnil removed this pull request from the merge queue due to a manual request Aug 3, 2023
@theo-mesnil theo-mesnil merged commit 9d506d8 into master Aug 3, 2023
4 checks passed
@theo-mesnil theo-mesnil deleted the feat-migrate-ariakit branch August 3, 2023 12:44
@anucreative
Copy link
Contributor

🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to Ariakit (reakit v2)
6 participants