fix: move basemap reference layers to base layers array

This will prevent them from overlapping the milepost features.

src/layers/MilepostLayer/milepost-line-layer/MilepostOffsetLineRenderer.ts

@@ -18,10 +18,7 @@ function createClickPointSymbolLayer() {
 		},
 	});
 
-	console.debug("clickPointSymbol", clickPointSymbol.toJSON());
-
 	const clickPointCimSymbol = convertToCIMSymbol(clickPointSymbol);
-	console.debug("cimClickPointSymbol", clickPointCimSymbol.toJSON());
 
 	const clickPointSymbolLayer =
 		clickPointCimSymbol.data.symbol?.symbolLayers?.filter(isCimVectorMarker)[0];

src/layers/MilepostLayer/symbol/index.ts

@@ -123,8 +123,3 @@ export const endpointMilepostSymbol = new CIMSymbol({
 		symbol: endpointCimPointSymbol,
 	},
 });
-
-/* __PURE__ */ console.debug(
-	"endMilepostSymbol",
-	endpointMilepostSymbol.toJSON(),
-);

src/layers/parcels/index.ts

@@ -4,7 +4,9 @@ import { parcelsLayer as waTechParcelsLayer } from "./watech";
 
 /**
  * Creates a group layer for parcels.
- * @returns A promise that resolves to the created group layer.
+ * The group layer lets the user to choose between the WA Tech Parcels layer
+ * and its fallback, the Regrid Parcels layer.
+ * @returns A group layer containing the WA Tech and Regrid Parcels layers
  */
 export function createParcelsGroupLayer(): GroupLayer {
 	const groupLayer = new GroupLayer({
@@ -14,6 +16,8 @@ export function createParcelsGroupLayer(): GroupLayer {
 	});
 	waTechParcelsLayer.visible = true;
 
+	// Setup up an error handler for the frequently-failing WA Tech Parcels layer.
+	// Once the error has been logged to the console, remove the error handler.
 	const waTechErrorHandler = waTechParcelsLayer.on(
 		"layerview-create-error",
 		(event) => {

src/main.ts

@@ -458,6 +458,21 @@ if (!testWebGL2Support()) {
 		}),
 	});
 
+	/**
+	 * Removes all reference layers from the given basemap and adds them to its
+	 * base layers.
+	 * @param basemap The basemap whose reference layers should be moved.
+	 */
+	const moveReferenceLayersToBaseLayers = (basemap: Basemap) => {
+		const refLayers = basemap.referenceLayers.removeAll();
+		basemap.baseLayers.addMany(refLayers);
+	};
+
+	// Move each basemap's reference layers to its base layers once they are loaded.
+	for (const bm of [imageryHybridBasemap, grayBasemap]) {
+		bm.when(moveReferenceLayersToBaseLayers);
+	}
+
 	const map = new EsriMap({
 		basemap: grayBasemap,
 		layers: [

src/milepost-info/index.ts

@@ -83,7 +83,6 @@ export async function getRouteList() {
 		]);
 		const url = new URL(`?${search.toString()}`, milepostsUrl);
 		const response = await fetch(url);
-		console.debug(response);
 		results = ((await response.json()) as FeatureSet).features.map(
 			(feature) => feature.attributes,
 		);