Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow redundant calls to claimInterface() and releaseInterface() #163

Merged
merged 2 commits into from
Jan 7, 2019

Conversation

reillyeon
Copy link
Collaborator

@reillyeon reillyeon commented Dec 22, 2018

This change updates the steps for claimInterface() and releaseInterface() so that calls requesting the state that the device is already in cause the Promise returned to be resolved without any further action taken.

Fixes #162.


Preview | Diff

Copy link
Collaborator

@odejesush odejesush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Reilly, I think that you meant that this fixes #162. Other than that, the change looks good.

This change updates the steps for claimInterface() and releaseInterface()
so that calls requesting the state that the device is already in cause
the Promise returned to be resolved without any further action taken.

Fixes WICG#162.
@reillyeon reillyeon merged commit cbd1135 into WICG:master Jan 7, 2019
@reillyeon reillyeon deleted the iface_noop branch January 7, 2019 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistency between open() and claimInterface()
2 participants