Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accessing interest groups from the same site #245

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Accessing interest groups from the same site #245

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ad670f1
Accessing interest groups from the same site
xxia2021 Dec 8, 2021
388bb8c
Update FLEDGE.md
xxia2021 Dec 8, 2021
6b81e80
Fixes typos
xxia2021 Dec 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion FLEDGE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,7 +299,7 @@ The arguments to `generateBid()` are:
'prevWins': [[time1,ad1],[time2,ad2],...],
}
```
* sameSiteInterestGroups: if the user is added to `interestGroup` on a single site, this argement contains a list of all other interest group objects added by that site; if the user is added to `interestGroup` on mutliple sites, this argument will be empty.
* sameSiteInterestGroups: if the user is added to `interestGroup` on a single site, this argument contains a list of all other interest group objects added by that site; if the user is added to `interestGroup` on mutliple sites, this argument will be a empty list.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit/typos:

  • Capital I for the first "if"
  • added by that site -> added on that site
  • Instead of the whole phrase "if the user ....", maybe just say "otherwise"?
  • mutliple -> multiple
  • a empty list -> an empty list

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed, thanks.


The output of `generateBid()` contains four fields:

Expand Down