Spec the reduce() operator
#171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benlesh
reviewed
Aug 27, 2024
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Aug 28, 2024
This CL specs the `reduce()` operator to have the same semantics as the `reduce()` operator in TC39's iterator helpers proposal. See WICG/observable#171. R=jarhar Bug: 40282760 Change-Id: I564b8cf0cf1fef81c0ee42808fad0a5aaddd2fc2
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Aug 28, 2024
This CL specs the `reduce()` operator to have the same semantics as the `reduce()` operator in TC39's iterator helpers proposal. See WICG/observable#171. R=jarhar Bug: 40282760 Change-Id: I564b8cf0cf1fef81c0ee42808fad0a5aaddd2fc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5817639 Commit-Queue: Dominic Farolino <[email protected]> Reviewed-by: Joey Arhar <[email protected]> Cr-Commit-Position: refs/heads/main@{#1348159}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Aug 28, 2024
This CL specs the `reduce()` operator to have the same semantics as the `reduce()` operator in TC39's iterator helpers proposal. See WICG/observable#171. R=jarhar Bug: 40282760 Change-Id: I564b8cf0cf1fef81c0ee42808fad0a5aaddd2fc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5817639 Commit-Queue: Dominic Farolino <[email protected]> Reviewed-by: Joey Arhar <[email protected]> Cr-Commit-Position: refs/heads/main@{#1348159}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Aug 28, 2024
This CL specs the `reduce()` operator to have the same semantics as the `reduce()` operator in TC39's iterator helpers proposal. See WICG/observable#171. R=jarhar Bug: 40282760 Change-Id: I564b8cf0cf1fef81c0ee42808fad0a5aaddd2fc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5817639 Commit-Queue: Dominic Farolino <[email protected]> Reviewed-by: Joey Arhar <[email protected]> Cr-Commit-Position: refs/heads/main@{#1348159}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Aug 30, 2024
… operator, a=testonly Automatic update from web-platform-tests DOM: Implement the `Observable#reduce()` operator This CL specs the `reduce()` operator to have the same semantics as the `reduce()` operator in TC39's iterator helpers proposal. See WICG/observable#171. R=jarhar Bug: 40282760 Change-Id: I564b8cf0cf1fef81c0ee42808fad0a5aaddd2fc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5817639 Commit-Queue: Dominic Farolino <[email protected]> Reviewed-by: Joey Arhar <[email protected]> Cr-Commit-Position: refs/heads/main@{#1348159} -- wpt-commits: 2a7b7ed6c088ae592ea3a1aa4437728596648cb8 wpt-pr: 47844
i3roly
pushed a commit
to i3roly/firefox-dynasty
that referenced
this pull request
Sep 3, 2024
… operator, a=testonly Automatic update from web-platform-tests DOM: Implement the `Observable#reduce()` operator This CL specs the `reduce()` operator to have the same semantics as the `reduce()` operator in TC39's iterator helpers proposal. See WICG/observable#171. R=jarhar Bug: 40282760 Change-Id: I564b8cf0cf1fef81c0ee42808fad0a5aaddd2fc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5817639 Commit-Queue: Dominic Farolino <[email protected]> Reviewed-by: Joey Arhar <[email protected]> Cr-Commit-Position: refs/heads/main@{#1348159} -- wpt-commits: 2a7b7ed6c088ae592ea3a1aa4437728596648cb8 wpt-pr: 47844
benlesh
approved these changes
Sep 3, 2024
There was a problem hiding this comment.
LGTM. As discussed offline, there's the obvious issue that there's not an analog for observable.reduce(fn) that takes a cancellation, because of the argument order: observable.reduce(fn, undefined, { signal }). But that doesn't seem like a big deal. If it ever IS a big deal, there could be an option added to ignore the initialValue, I suppose. But that's one of those "why is this there?" sort of things. :)
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Sep 6, 2024
… operator, a=testonly Automatic update from web-platform-tests DOM: Implement the `Observable#reduce()` operator This CL specs the `reduce()` operator to have the same semantics as the `reduce()` operator in TC39's iterator helpers proposal. See WICG/observable#171. R=jarhar Bug: 40282760 Change-Id: I564b8cf0cf1fef81c0ee42808fad0a5aaddd2fc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5817639 Commit-Queue: Dominic Farolino <domchromium.org> Reviewed-by: Joey Arhar <jarharchromium.org> Cr-Commit-Position: refs/heads/main{#1348159} -- wpt-commits: 2a7b7ed6c088ae592ea3a1aa4437728596648cb8 wpt-pr: 47844 UltraBlame original commit: a0a2d5d15343b7dd8ba7b31bd8b0114df5e869a1
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Sep 6, 2024
… operator, a=testonly Automatic update from web-platform-tests DOM: Implement the `Observable#reduce()` operator This CL specs the `reduce()` operator to have the same semantics as the `reduce()` operator in TC39's iterator helpers proposal. See WICG/observable#171. R=jarhar Bug: 40282760 Change-Id: I564b8cf0cf1fef81c0ee42808fad0a5aaddd2fc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5817639 Commit-Queue: Dominic Farolino <domchromium.org> Reviewed-by: Joey Arhar <jarharchromium.org> Cr-Commit-Position: refs/heads/main{#1348159} -- wpt-commits: 2a7b7ed6c088ae592ea3a1aa4437728596648cb8 wpt-pr: 47844 UltraBlame original commit: a0a2d5d15343b7dd8ba7b31bd8b0114df5e869a1
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this pull request
Sep 9, 2024
… operator, a=testonly Automatic update from web-platform-tests DOM: Implement the `Observable#reduce()` operator This CL specs the `reduce()` operator to have the same semantics as the `reduce()` operator in TC39's iterator helpers proposal. See WICG/observable#171. R=jarhar Bug: 40282760 Change-Id: I564b8cf0cf1fef81c0ee42808fad0a5aaddd2fc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5817639 Commit-Queue: Dominic Farolino <[email protected]> Reviewed-by: Joey Arhar <[email protected]> Cr-Commit-Position: refs/heads/main@{#1348159} -- wpt-commits: 2a7b7ed6c088ae592ea3a1aa4437728596648cb8 wpt-pr: 47844
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This specs the
reduce()operator discussed in #126. Tests will be upstreamed in https://chromium-review.googlesource.com/c/chromium/src/+/5817639. That should leave onlycatch()andfinally()operators left.Preview | Diff