Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Content-Security-Policy" to speculation rules explainer #213

Merged
merged 2 commits into from
Nov 22, 2022

Conversation

toyoshim
Copy link
Contributor

The new section explains how the prerender and prefetch follow the Content-Security-Policy. They respect the existing script-src, but inline-speculation-rules is also added as a new source to permit inline speculationrules.

The new section explains how the prerender and prefetch follow the
Content-Security-Policy. They respect the existing `script-src`, but
`inline-speculation-rules` is also added as a new source to permit
inline speculationrules.
@toyoshim
Copy link
Contributor Author

This is a revised proposal that is based on discussion at #209

Copy link
Collaborator

@jeremyroman jeremyroman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggested tweaks to working, but lgtm otherwise.

triggers.md Outdated Show resolved Hide resolved
triggers.md Outdated Show resolved Hide resolved
triggers.md Outdated Show resolved Hide resolved
triggers.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with Jeremy's suggested fixes. (I also edited Jeremy's suggested fixes to change some curly quotes to straight quotes.)

Rephrasing for better explanations and replacing `Speculation-Rules` with just
"speculation rules" as the former is used to represent the HTTP header name.

Co-authored-by: Jeremy Roman <[email protected]>
@toyoshim
Copy link
Contributor Author

Thanks!
This is my first code review at the GitHub system and I might make a mistake. But I think I merged @jeremyroman 's suggestions into the pull request, and this PR is now ready for the 2nd review or merging.
Please let me know if I still need some actions.

@jeremyroman jeremyroman merged commit 97d83e9 into WICG:main Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants