Skip to content

Set mousemove and pointermove events during dragging and resizing to be excluding inputs #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LanWei22 wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Set mousemove and pointermove events during dragging and resizing to be excluding inputs #103

Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
c1feba0
Adding mousemove and pointermove after mousedown and pointerdown to b…
LanWei22 May 1, 2021
eb02c4f
pointercancel event not excluding input
LanWei22 May 3, 2021
595e54e
Update index.bs
LanWei22 Jun 2, 2021
2b392a3
Update index.bs
LanWei22 Jun 9, 2021
cef43ed
Update index.bs
LanWei22 Jun 9, 2021
5ff58c2
Update index.bs
LanWei22 Jul 15, 2021
d73ca60
Update index.bs
LanWei22 Jul 16, 2021
4df957a
Update index.bs
LanWei22 Jul 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions index.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,9 +413,14 @@ The user agent may delay the reporting of layout shifts after a
until such time as it is known that the event does not begin a fling or scroll
gesture.

The <a href="https://www.w3.org/TR/uievents/#event-type-mousemove">mousemove</a> and
<a href="https://www.w3.org/TR/pointerevents/#the-pointermove-event">pointermove</a>
events are also not excluding inputs.
The <a href="https://www.w3.org/TR/uievents/#event-type-mousemove">mousemove</a> events after the
Copy link
Collaborator

@npm1 npm1 May 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: I think what we want is: pointermove after pointerdown that is not followed by pointercancel, right? I.e. a way the current wording could be interpreted is that the following sequence would consist of an excluding pointermove:
pointerdown, pointermove, pointercancel...
And I think we want that pointermove to not count as an excluding input, right? So in a sense we kinda need to wait until we know that pointercancel won't be fired in order to know that pointermove was excluding. Does this match the implementation, and does it make sense to you?

Copy link
Author

@LanWei22 LanWei22 Jun 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have made some changes, now pointermove events are not excluding inputs.

<a href="https://www.w3.org/TR/uievents/#event-type-mousedown">mousedown</a> event and the
<a href="https://www.w3.org/TR/pointerevents/#the-pointermove-event">pointermove</a> events after
the <a href="https://www.w3.org/TR/pointerevents/#the-pointerdown-event">pointerdown</a> event
with no <a href="https://www.w3.org/TR/pointerevents/#the-pointercancel-event">pointercancel</a>
event fired, which trigger dragging elements around or resizing elements but not scrolling, should be excluding inputs.
The <a href="https://www.w3.org/TR/pointerevents/#the-pointercancel-event">pointercancel</a> event is
fired when touch scroll starts, so it is not an excluding input.

{{LayoutShift}} interface {#sec-layout-shift}
=======================================
Expand Down