Properly exclude 'CrashReportBody' from exported IDL #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @tabatkins @foolip @tidoust to see if I'm doing this right this time. Based on discussion at #8 (comment) - our overall goal is that this IDL will never be webexposed because the page by definition cannot receive a report for itself crashing. |
foolip
reviewed
Jul 22, 2020
| }; | ||
|
|
||
| </pre> | ||
| <pre class="idl highlight def"></pre> |
There was a problem hiding this comment.
Heh, I think you've uncovered a Bikeshed bug: that it generates an IDL index even if no IDL remained after removing stuff with class="extract" :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #8 (comment)
💥 Error: 500 Internal Server Error 💥
PR Preview failed to build. (Last tried on Jul 22, 2020, 3:05 PM UTC).
More
PR Preview relies on a number of web services to run. There seems to be an issue with the following one:
🚨 Spec Generator - Spec Generator is the web service used to build specs that rely on ReSpec.
🔗 Related URL
If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.