Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: delegate cdash status into the cdash-status action #38

Merged
merged 2 commits into from
Mar 21, 2025

Conversation

vicentebolea
Copy link
Collaborator

@vicentebolea vicentebolea commented Mar 20, 2025

I have recently created a github action that setup the cdash status as shown here: https://github.com/marketplace/actions/cdash-status

In this PR remove the adhoc implementation of the cdash status and delegate into this action. This will help me not to duplicate effort across the different project that uses this.

@vicentebolea vicentebolea force-pushed the use-setup-cdash-action branch 2 times, most recently from eba7ff2 to 80e71ba Compare March 20, 2025 23:32
@vicentebolea vicentebolea self-assigned this Mar 20, 2025
@vicentebolea vicentebolea requested a review from kmorel March 20, 2025 23:37
@vicentebolea vicentebolea changed the title ci: delegate cdash status into the setup-cdash action ci: delegate cdash status into the cdash-status action Mar 20, 2025
@vicentebolea vicentebolea force-pushed the use-setup-cdash-action branch from 80e71ba to 372ffa6 Compare March 21, 2025 00:39
Copy link
Collaborator

@kmorel kmorel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that this is working correctly. The CDash entry in the checks is no longer showing up.

Screenshot 2025-03-21 at 7 31 52 AM

@vicentebolea
Copy link
Collaborator Author

vicentebolea commented Mar 21, 2025

@kmorel we do not have the cdash status since I removed the Circle CI infrastructure code. The reason of the new workflow not running now is that this workflow runs in pull_request_head type of events. This is an interesting workaround for Github to run pull_requests workflows from forks and sharing secrets with it (env variables) while avoiding leaking secrets. These workflows runs with the workflow files as they are in the main branch (as opposed to the pull request).

@kmorel
Copy link
Collaborator

kmorel commented Mar 21, 2025

@vicentebolea I only understood the first sentence of that.

So, where do you go to find the CDash reporting for a PR?

@vicentebolea
Copy link
Collaborator Author

vicentebolea commented Mar 21, 2025

?

We can only test this kind of github workflow once it is merged in main, this is by design of pull_request_head types of workflows.

@kmorel
Copy link
Collaborator

kmorel commented Mar 21, 2025

We can only test this kind of github workflow once it is merged in main, this is by design of pull_request_head types of workflows.

OK. So, you are saying that after this is merged in, we will see the CDash link in the list of checks. If that is the case, then +1.

@kmorel kmorel self-requested a review March 21, 2025 16:33
@vicentebolea vicentebolea merged commit a41972e into Viskores:main Mar 21, 2025
4 of 5 checks passed
@vicentebolea vicentebolea deleted the use-setup-cdash-action branch March 21, 2025 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants