Improve PE module when scanning memory and fix PE certificate parsing #1657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…WOW64 unless the target is also WOW64
* The X509_NAME_oneline function was being used to extract the certificate issuer and subject. The function is being provided a static buffer which is only 254 chars in size, meaning that if either string is larger they will be truncated and essential information may be lost. * Increasing the buffer size or using a dynamic buffer could solve the issue, however the X509_NAME_oneline function is deprecated and its use is strongly discouraged. Instead, the issue can be fixed using the newer X509_NAME_print_ex function which will output the full string in a standard format. * Unicode data is escaped in the output string by default, so ASN1_STRFLGS_ESC_MSB is explicitly cleared to force the output of UTF8 encoded data. This allows matching unicode byte sequences in a more natural and expected manner. * This change has the side effect of addressing VirusTotal#1392
niallnsec
force-pushed
the
master
branch
3 times, most recently
from
0d6be86
to
5d498a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1372 and #1392