Skip to content

Conversation

@henrykavalev
Copy link

Description

If requesting a variation product with images that are saved within the parent product, then the id is manually set to null. This PR is setting id to the parent product image id. That way it will return the same image id as if one would request the parent product image id.

References

QA-test:

Jira-link:

Artifact URL:

@CLAassistant
Copy link

CLAassistant commented Oct 4, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ OlegoO
❌ henrykavalev
You have signed the CLA already but the status is still pending? Let us recheck it.

@vc-ci
Copy link
Contributor

vc-ci commented Oct 4, 2023

Reveiw task created: https://virtocommerce.atlassian.net/browse/PT-13854

@artem-dudarev
Copy link
Contributor

Why do you need an inherited image id?

@henrykavalev
Copy link
Author

Since the other parameters were inherited from parentAssetBase, it led on our side to the question why it is not done for the id as well. For us it is easier to differentiate between pictures based on the id instead of the name. For example working on frontend with Keys of the HTML Lists Items, where we could use Id as the Key to avoid duplicated image names.

@henrykavalev
Copy link
Author

Hello together, since there are no updates on this issue for some time now, I wanted to ask whether this issue will be implemented or if I can help in any other way regarding this suggestion?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants