Reduce allocations in #with_collection #2333
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution! |
joelhawksley
added a commit
that referenced
this pull request
Jun 9, 2025
* Deprecate use_helper(s) in favor of include MyHelper or helpers. (#2331) * Reduce allocations in #with_collection (#2333) * Add test of number of allocations when rendering with with_collection * Ensure one-time initializations are done before testing allocations * Cache calculated collection parameter * Cache collection_counter_parameter * Cache collection_iteration_parameter * Cache initialize_parameter_names * Add expected number of allocations for all tested Ruby/Rails combinations * Remove code handling obsolete Rails version * fix allocations --------- Co-authored-by: Matijs van Zuijlen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Speed up rendering when there are lots of calls to
#with_collectionfor the same componen, for example when rendering a collection of items, where each item contains a collection of sub-items.What approach did you choose and why?
I focused on reducing redundant allocation of string objects. This is because rack-mini-profiler's flamegraph showed me lots of repeats of the same string interpolation.
Anything you want to highlight for special attention from reviewers?
The code setting the expected number of allocations will have to be updated to include values for all the relevant Ruby and Rails versions.