Restore delete key behavior on articles #1755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make Delete key delete the article when focus is on the article content panel. Fix issue ViennaRSS#1735
Eitot
approved these changes
Jun 23, 2024
There was a problem hiding this comment.
I was concerned about removing the first responder check. I tested pressing the delete key while having the focus (first responder status) on other parts of the window/app, but have not found unexpected behaviour. I guess since MessageListView is the origin of the ‑keyDown: method, it is fine here to check only whether the main tab is selected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make Delete key delete the article when focus is on the article content panel.
Fix issue #1735