Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling of FoldersTree manual sort issues #1754

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

barijaona
Copy link
Member

Should fix issue #1743 : Vienna abruptly auto-sorts folders in the alphabetical order on the left panel

@barijaona
Copy link
Member Author

Might also help with issue #1742

@barijaona
Copy link
Member Author

Should also help with #1732 and #1734

Implement a less crude way to recover when ‑loadTree:rootNode: returns NO:
reattach missing folders directly under the root folder.

Expected to improve on issue ViennaRSS#1743 : Vienna abruptly auto-sorts folders
in the alphabetical order on the left panel
@barijaona barijaona changed the title Remove useless and dangerous sort folder setting Improve handling of FoldersTree manual sort issues Jun 26, 2024
@barijaona
Copy link
Member Author

In this new attempt, I implemented a less crude way to recover when ‑loadTree:rootNode: returns NO.
Not sure how to test though, I didn't find a way to recreate the problem.

@barijaona barijaona requested a review from Eitot June 26, 2024 06:43
@Eitot
Copy link
Contributor

Eitot commented Jun 26, 2024

Thanks. We just have to keep an eye on this.

@josh64x2 josh64x2 merged commit c292317 into ViennaRSS:master Jun 28, 2024
2 checks passed
@barijaona barijaona deleted the issue-1743 branch June 29, 2024 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants