Remove legacy WebView browser #1675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barijaona
added
the
changes localisations 💬
Eitot
reviewed
Apr 23, 2023
Vienna/Sources/Preferences window/AdvancedPreferencesViewController.h
Outdated
Show resolved
Hide resolved
Eitot
force-pushed
the
removeOldBrowser
branch
2 times, most recently
from
b915b87
to
98923ee
Compare
barijaona
force-pushed
the
removeOldBrowser
branch
from
98923ee
to
7db80fd
Compare
barijaona
force-pushed
the
removeOldBrowser
branch
from
72c1fc2
to
ee7e041
Compare
Eitot
requested changes
Apr 27, 2023
barijaona
force-pushed
the
removeOldBrowser
branch
from
ee7e041
to
f26578a
Compare
Eitot
previously approved these changes
Apr 29, 2023
|
Yes, I wanted to all the time, but I hope to find a moment for it this weekend! |
Eitot
reviewed
Apr 29, 2023
Force use of new browser
The WebKit browser does not use this. The functionality is included in the "Print…" menu item.
The WebDownloadDelegate was used by the now removed TabbedWebView.
Fix failure of URLFormatterTest on macOS 12
barijaona
force-pushed
the
removeOldBrowser
branch
from
acc8cb0
to
5d19f2a
Compare
This was left behind in 96d6500 when the Legacy WebView was refactored.
I kept the change to a minimum, just removing the test on plugin taking control, as it's unclear what situations might trigger the -webView:didFailNavigation:withError delegate. Note: WebKitErrorPlugInWillHandleLoad was defined by WebKitErrors.h https://github.com/WebKit/WebKit/blob/main/Source/WebKitLegacy/mac/Misc/WebKitErrorsPrivate.h#L33-L34 It must be noted that this file was updated until relatively recently, apparently because WebKit is not yet fully modularized.
Eitot
approved these changes
May 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.