Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dont' update private key after updating license key #355

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

pccr10001
Copy link
Contributor

@pccr10001 pccr10001 commented Nov 23, 2023

Related to #348
After checking API call from 1.1.1.1 application on Android device, I found 1.1.1.1 app will not update private key after updating license key.
IPv6 address is created and bound to regId and public key, but updating the public key will not update the binding of IPv6 address, this causes IPv6 address may different from new and old public key binding, so IPv6 connection is broken.
So I removed updating public key and generating new private key on changing license key then IPv6 is working now.

@d-sushko
Copy link

This is a very important commit, as it fixes the IPv6 connections issues. Please, check and approve as soon as possible.

@d-sushko
Copy link

Applied your fix and rebuilt wgcf, now IPv6 is working, thanks a lot

@kkbeta
Copy link

kkbeta commented Dec 2, 2023

could You tell me how to do it ? step by step plz,thx
I can't understand what is "So I removed updating public key and generating new private key on changing license key then IPv6 is working now." mean。

@ViRb3
Copy link
Owner

ViRb3 commented Dec 2, 2023

I'll merge this later this week and make an official release, currently not at computer, apologies.

@shekhawat2
Copy link

I'll merge this later this week and make an official release, currently not at computer, apologies.

merge wen?

@ViRb3 ViRb3 merged commit 2fe51a1 into ViRb3:master Dec 19, 2023
@ViRb3
Copy link
Owner

ViRb3 commented Dec 19, 2023

Merged and released in v2.2.20. Sorry for the delay and thanks for the contribution!

@ihipop ihipop mentioned this pull request Sep 24, 2024
ihipop added a commit to ihipop/wgcf that referenced this pull request Sep 27, 2024
ViRb3 added a commit that referenced this pull request Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants