Skip to content

Conversation

@hissssst
Copy link

@hissssst hissssst commented Aug 2, 2024

defmodule :my_module do
  use Sybil
end

Is a valid code

Copy link
Collaborator

@vereis vereis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I honestly had no idea this was a thing! Thanks!

@vereis
Copy link
Collaborator

vereis commented Aug 3, 2024

@hissssst feel free to just add a dialyzer ignore for that warning which breaks CI. Its happening because atom() is already covered as part of the type spec so you adding the | atom() to the module AST type causes it to overlap another @spec declaration.

I've generally always liked to keep multiple specs despite the fact that these get collapsed into one spec by dialyzer for clearer documentation purposes, so I'm not too worried about the domain overlap here.

If possible, we can just disable the check for this one file, but if need be, feel free to set it in mix.exs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants