cd: deploy to k8s and add workflow #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Charlie-XIAO
commented
Dec 5, 2024
Comment on lines
+35
to
+37
| FRONTEND_URL = os.getenv("FRONTEND_URL") | ||
| CHROMADB_HOST = os.getenv("CHROMADB_HOST", "localhost") | ||
| SERVER_ROOT_PATH = os.getenv("SERVER_ROOT_PATH", "") |
There was a problem hiding this comment.
| Header | Development | Production | Explanation |
|---|---|---|---|
FRONTEND_URL |
http://localhost:8080 |
None | In development this is needed for CORS. In production frontend and backend are same origin (one at / and one at /api/). |
CHROMADB_HOST |
chromadb |
35.188.136.220 |
In development this is according to the docker network created by docker compose. In production this is the external IP of the VM on which chromadb is deployed #51. |
SERVER_ROOT_PATH |
Empty string | /app |
In development the backend is at root of localhost port 8001. In production it is served at /api/ and we need openapi docs to be aware. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the Ansible playbook for deploying K8S cluster. The K8S cluster consists of only the frontend and the backend, where the vector database is on an individual VM outside the cluster #51.