Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix window controls (popouts and visual refresh) and focus window method by patching window controls wrapper module #1104

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Sqaaakoi
Copy link

Fixes #1077
Fixes #964

This patches Discord's module that wraps around native IPC methods for windowing and some other utilities to call VesktopNative.win methods instead of DiscordNative.window methods
This includes focus which was used by RPC deep linking. No difference will occur from this change, but if any of those other handlers are later supported through arRPC, it won't be necessary to patch the focus method in those handlers.

This does not fix the missing always on top support in call popouts (doesnt work on wayland, I gave up on fixing that for that reason)

@Vendicated
Copy link
Member

do not remove the old patches. not everyone is using Visual Refresh

@Vendicated
Copy link
Member

we should hide this discord titlebar if you have discord titlebar disabled

you won't be able to access your inbox but welp blame discord for being braindead and not testing their web app

image

@Vendicated
Copy link
Member

they will probably fix it soon

@Covkie
Copy link
Collaborator

Covkie commented Mar 27, 2025

we should hide this discord titlebar if you have discord titlebar disabled

IMO no, the Linux desktop client has it like that too. People always have UserCSS if they want to change it,,

@Vendicated
Copy link
Member

looks like shit and expecting people to fix shit with css is bad UX

@Covkie
Copy link
Collaborator

Covkie commented Mar 27, 2025

Should be a vencord plugin to unify the two bars then, since its not Vesktop specific

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants