-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvement: Password input #770
Conversation
Sweet this addresses my issues with #768. I'll give this a test when I wake up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 968977f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only problem was the lack of carriage return when using multiple inputs; or seeing the response from an rcp command:
$ ./veil-cli -stdinrpcpass -stdinwalletpassphrase walletpassphrase
RPC password> Wallet passphrase> error code: -1
These have been added:
$ ./veil-cli -stdinrpcpass -stdinwalletpassphrase walletpassphrase
RPC password>
Wallet passphrase>
error: Could not connect to the server
ACK 27e0d2b
@codeofalltrades give it another look please
ACK Tested on Win64 build.
This gave a prompt as below, and correctly unlocked the wallet. |
|
Problem
This PR aims to improve the cli program by bringing in hidden password input.
Root Cause
We don’t want to show passwords in clear text.
Solution
Bring in two commits from Bitcoin upstream.
One introduces the stdin interfaces, the other to patch in -stdin* interfaces.
Unit Testing Results
→ -stdin
→ -stdinrpcpass
→ -stdinwalletpassphrase