Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing the APFL implementation that occurs if there are frozen layers in a model #38

Merged
merged 4 commits into from
Jul 13, 2023
Merged

Fixing the APFL implementation that occurs if there are frozen layers in a model #38

merged 4 commits into from
Jul 13, 2023

Conversation

emersodb
Copy link
Collaborator

@emersodb emersodb commented Jul 9, 2023

See Title

Base automatically changed from dbe/fix_scaffold to main July 12, 2023 12:58
yc7z
yc7z approved these changes Jul 13, 2023
View reviewed changes
Copy link
Collaborator

@yc7z yc7z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@emersodb emersodb merged commit 57a86f6 into main Jul 13, 2023
2 checks passed
@emersodb emersodb deleted the dbe/fix_apfl_with_frozen_params branch July 13, 2023 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yc7z yc7z yc7z approved these changes

@fatemetkl fatemetkl Awaiting requested review from fatemetkl

@jewelltaylor jewelltaylor Awaiting requested review from jewelltaylor

@sanaAyrml sanaAyrml Awaiting requested review from sanaAyrml

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emersodb @yc7z