Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Tests for the APFL and FENDA layer exchange flow. #35

Merged
merged 7 commits into from
Jul 13, 2023

Conversation

emersodb
Copy link
Collaborator

@emersodb emersodb commented Jul 6, 2023

I realized we don't have any tests to ensure that FENDA and APFL submodule exchange works as expected. So this PR adds in tests to ensure that the fixed layer exchange modules of the APFL and FENDA approaches function as expected. Also including some init.py files to ensure that the tests function properly in vs code.

Some black formatting changes were dragged in. Not sure why, but oh well.

…e APFL and FENDA approaches function as expected. Also including some init.py files to ensure that the tests function properly in vs code.
@emersodb emersodb changed the base branch from main to dbe/fix_apfl_with_frozen_params July 9, 2023 19:17
Base automatically changed from dbe/fix_apfl_with_frozen_params to main July 13, 2023 20:50
Copy link
Collaborator

@jewelltaylor jewelltaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates look good to me!

@emersodb emersodb merged commit 5513c2d into main Jul 13, 2023
2 checks passed
@emersodb emersodb deleted the dbe/test_fenda_apfl_exchange branch July 13, 2023 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants