Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More Masked Layers for FedPM #283

Merged
merged 5 commits into from
Nov 13, 2024
Merged

More Masked Layers for FedPM #283

merged 5 commits into from
Nov 13, 2024

Conversation

yc7z
Copy link
Collaborator

@yc7z yc7z commented Nov 11, 2024

PR Type

[Feature]

Added masked implementations for transposed convolution, layer normalization, and batch normalization layers.

Tests Added

Tests in test_masked_layers have been added to test the functionality of the new masked layers.

@yc7z yc7z requested a review from emersodb November 12, 2024 15:02
Copy link
Collaborator

@emersodb emersodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks really nice. Some pretty minor comments!

self,
in_channels: int,
out_channels: int,
kernel_size: _size_1_t,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Torch has such descriptive types 😂

fl4health/model_bases/masked_layers/masked_conv.py Outdated Show resolved Hide resolved
fl4health/model_bases/masked_layers/masked_conv.py Outdated Show resolved Hide resolved
fl4health/model_bases/masked_layers/masked_conv.py Outdated Show resolved Hide resolved
fl4health/model_bases/masked_layers/masked_conv.py Outdated Show resolved Hide resolved
fl4health/model_bases/masked_layers/masked_linear.py Outdated Show resolved Hide resolved
@yc7z yc7z merged commit 32c0ee9 into main Nov 13, 2024
6 checks passed
@yc7z yc7z deleted the more-masked-layers branch November 13, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants