Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clippy warnings and run rustfmt #5764

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

mkrasnitski
Copy link
Contributor

Clippy was complaning about some uses of std::mem::transmute, so I changed them to use simple as casting instead. Additionally, ran cargo fmt --all to avoid extraneous formatting changes from leaking into future PRs.

@emesare emesare self-assigned this Jul 29, 2024
@emesare emesare self-requested a review July 29, 2024 11:20
@emesare
Copy link
Member

emesare commented Aug 24, 2024

Due to the nature of formatting all of the rust api, we are instead going to format the code in rust_break_everything. Those refactors also will create large diffs, and doing them both at the same time is better than if we were to go ahead and format now, then follow it shortly after with another large refactor.

I am going to keep this PR up until rust_break_everything is merged.

@emesare emesare removed their request for review August 24, 2024 15:29
@emesare emesare added the Component: Rust API Issue needs changes to the Rust API label Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Rust API Issue needs changes to the Rust API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants