Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error Catcher rewrite #764

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

gdavid04
Copy link
Contributor

Changes Error Catcher to have its own output instead of replacing the output of its target.


This change would make Error Catchers easier to understand by making them work in a more intuitive way, while also giving advanced users and addon developers more options.

The same piece could have multiple Error Catchers attached to it, all of them completely independent from each other, unlike the current system which is limited to one per target. Addons could add pieces that provide more advanced error handling such as output whether an error occured somewhere.

TODO before merge:

  • Use getter instead of SpellParam Subclass
  • Don't set grid position of SpellRuntimeExceptions automatically when already set
  • Make fallback optional (Error Catcher outputs nothing when fallback is not set, useful for tricks)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant