Separation of AncientWillContainer and TerrasteelHelmItem #4749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemisSystem
added
the
after-1.21-port
|
This should be ready for 1.21.1 now. Feel free to edit anything if need be. |
|
We'll have a look at this when the port is complete! Kinda hard to review a PR when the project doesn't compile. Or maybe we'll incorporate the changes during the port |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes should allow for a better implementation by other mods of the AncientWillContainer interface to new armor pieces. Works for both fabric and forge.
Should terraWillCritTarget inside PlayerMixin be refactored to WillCritTarget as it will not contain only a target added by the terrahelm, but by all items that implements AncientWillContainer?
Fixes #4746
PS: Sorry for closing and remaking this pr, had messed up my fork.