Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to Node 20 to match WP core defaults #2696

Merged
merged 2 commits into from
Jan 3, 2024
Merged

Switch to Node 20 to match WP core defaults #2696

merged 2 commits into from
Jan 3, 2024

Conversation

tomjn
Copy link
Member

@tomjn tomjn commented Jan 2, 2024 •
edited
Loading

WP Core and Gutenberg use Node 20, and have nvm rc files if that changes:

Checks

  • I've updated the changelog.
  • I've tested this PR
  • This PR is for the develop branch not the stable branch.
  • This PR is complete and ready for review.

@update-docs Update Docs
Copy link

update-docs bot commented Jan 2, 2024 •
edited by unfurl-links bot
Loading

Thanks for opening this pull request! Make sure CHANGELOG.md gets updated with this change, additionally any docs that need updated can be found at https://github.com/Varying-Vagrant-Vagrants/varyingvagrantvagrants.org

GitHub
The VVV docs and website. Contribute to Varying-Vagrant-Vagrants/varyingvagrantvagrants.org development by creating an account on GitHub.

@tomjn tomjn marked this pull request as ready for review January 2, 2024 09:45
@tomjn tomjn added this to the 3.13 milestone Jan 2, 2024
msaggiorato
msaggiorato approved these changes Jan 3, 2024
View reviewed changes
Copy link
Member

@msaggiorato msaggiorato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Nothing should break because of this.

@tomjn tomjn merged commit 4ba78d6 into develop Jan 3, 2024
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msaggiorato msaggiorato msaggiorato approved these changes

Assignees
No one assigned
Labels
provisioner:core
Projects
None yet
Milestone
3.13
Development

Successfully merging this pull request may close these issues.
2 participants
@tomjn @msaggiorato