[TF2/ALL] Temporary workaround for debug build of libprotobuf corrupting data (on MSVC). #1303
+21
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's an issue with the debug build of protobuf not playing nice (likely only happening with MSVC). We have to rely on using the release build, but the iterator debug level is in the way. So we have to go about and satisfying it's conditions.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently there's an issue with the debug build of
libprotobuf.lib, causing inventory data to become corrupt when converted from an API response (TF2 inventory.)As a temporary solution until a compatible debug build of
libprotobuf.libis created. This will link against the release build oflibprotobuf.lib.However to be able to link objects together, we unfortunately have to allow iterator debug level mismatch and set the iterator debug level to 0 for all projects.
This should be only applying to projects built on the Source SDK.
This have not been tested on Linux/OSX. (But shouldn't break anything there.)
I've tested it both compiling
gameandgamedllsFor a more in-depth explanation see #663 (comment)