Radar - bomb position, adjust icon size #129
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WolverinDEV
requested changes
Feb 26, 2024
|
|
||
| #[derive(Serialize, Deserialize, Clone, Debug)] | ||
| #[serde(rename_all = "camelCase")] | ||
| pub struct RadarBombInfo { |
There was a problem hiding this comment.
Maybe add a flag whatever it's planted or not.
Maybe use a similar system as I've done here including the bomb state: https://github.com/Valthrun/Valthrun/blob/master/controller/src/enhancements/bomb.rs#L51
In your case it would be RadarBombInfo containing the position and the C4State which may includes Dropped, Carried as well
There was a problem hiding this comment.
I added more data into RadarBombInfo. You can check it out.
maxwelbm
approved these changes
Feb 29, 2024
PetrSeifert
force-pushed
the
show_bomb_radar
branch
from
204e2cb
to
1a05da3
Compare
|
Hey, I've merged manually your changes |
WolverinDEV
added a commit
that referenced
this pull request
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bomb position is now shown on the radar.
Added drawer where is slider for setting of icon size.