Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type hints for better code clarity and linting #86

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add type hints for better code clarity and linting #86

wants to merge 3 commits into from

Conversation

meowmeowahr
Copy link

These changes add proper type hints for all of the functions and sockets, for better code clarity and improved linting.

This would fix some issues, like the following, even thought the code runs as intended.
Screenshot

@meowmeowahr meowmeowahr marked this pull request as draft November 10, 2024 02:52
@meowmeowahr meowmeowahr marked this pull request as ready for review November 10, 2024 02:57
kalvdans
kalvdans approved these changes Nov 10, 2024
View reviewed changes
Copy link

@kalvdans kalvdans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Return values are still not annotated, but no problem to leave them for later.

(I have no merge rights to this repo, just a random user of the library)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalvdans kalvdans kalvdans approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meowmeowahr @kalvdans