Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Calendar): restrict min and max years #6933

Merged
merged 1 commit into from
May 20, 2024

Conversation

BlackySoul
Copy link
Contributor


  • Unit-тесты

Описание

В dayjs есть проблемы с годами < 100, поэтому ограничиваем нижнюю границу этим числом
Верхнюю границу ограничила 9999, потому что есть проблемы с визуальным отображением на некоторых мобильных устройствах

@BlackySoul BlackySoul requested a review from a team as a code owner May 20, 2024 08:45
@github-actions github-actions bot added the patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча label May 20, 2024
Copy link
Contributor

size-limit report 📦

Path Size
JS 366.13 KB (+0.02% 🔺)
JS (gzip) 112.39 KB (+0.05% 🔺)
JS (brotli) 92.73 KB (-0.01% 🔽)
JS import Div (tree shaking) 1.42 KB (0%)
CSS 273.88 KB (0%)
CSS (gzip) 35.6 KB (0%)
CSS (brotli) 28.85 KB (0%)

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

e2e tests

Playwright Report

Copy link
Contributor

👀 Docs deployed

Commit 74c7307

Copy link

codecov bot commented May 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.36%. Comparing base (ae5ca12) to head (74c7307).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6933      +/-   ##
==========================================
+ Coverage   83.35%   83.36%   +0.01%     
==========================================
  Files         351      351              
  Lines       10469    10477       +8     
  Branches     3475     3477       +2     
==========================================
+ Hits         8726     8734       +8     
  Misses       1743     1743              
Flag Coverage Δ
unittests 83.36% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BlackySoul BlackySoul removed the patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча label May 20, 2024
@BlackySoul BlackySoul merged commit c8cc012 into master May 20, 2024
26 checks passed
@BlackySoul BlackySoul deleted the fix/6921/Calendar_fix_years branch May 20, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: В Calendar есть возможность выбрать отрицательные года
3 participants