Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Spacing): Use vkui-tokens in the Spacing component #6925

Merged
merged 2 commits into from
May 21, 2024

Conversation

mendrew
Copy link
Contributor

@mendrew mendrew commented May 17, 2024


  • e2e-тесты
  • Дизайн-ревью
  • Документация фичи

Описание

Добавляем к свойству size возможность передавать строковые значния размеров, соответствующие размерам из системы расстояний (#6684)

@mendrew mendrew added this to the v6.1.0 milestone May 17, 2024
@mendrew mendrew self-assigned this May 17, 2024
@mendrew mendrew changed the title feat(Spacing): Use vkui-tokens Spacing component feat(Spacing): Use vkui-tokens in the Spacing component May 17, 2024
Copy link
Contributor

github-actions bot commented May 17, 2024

size-limit report 📦

Path Size
JS 366.19 KB (+0.04% 🔺)
JS (gzip) 112.38 KB (+0.04% 🔺)
JS (brotli) 92.63 KB (-0.12% 🔽)
JS import Div (tree shaking) 1.42 KB (0%)
CSS 273.88 KB (0%)
CSS (gzip) 35.6 KB (0%)
CSS (brotli) 28.85 KB (0%)

Copy link

codesandbox-ci bot commented May 17, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

github-actions bot commented May 17, 2024

e2e tests

Playwright Report

Copy link
Contributor

github-actions bot commented May 17, 2024

👀 Docs deployed

Commit 71d78db

Copy link

codecov bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.36%. Comparing base (ae5ca12) to head (71d78db).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6925   +/-   ##
=======================================
  Coverage   83.35%   83.36%           
=======================================
  Files         351      351           
  Lines       10469    10475    +6     
  Branches     3475     3476    +1     
=======================================
+ Hits         8726     8732    +6     
  Misses       1743     1743           
Flag Coverage Δ
unittests 83.36% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mendrew mendrew marked this pull request as ready for review May 17, 2024 14:17
@mendrew mendrew requested a review from a team as a code owner May 17, 2024 14:17
Copy link
Contributor

@inomdzhon inomdzhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💅

@mendrew mendrew merged commit 4a50b3f into master May 21, 2024
26 checks passed
@mendrew mendrew deleted the mendrew/Spacing/use-spacing-tokens branch May 21, 2024 15:07
@vkcom-publisher
Copy link
Contributor

v6.1.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants