Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Popover): add disablePlacementFlip prop #6922

Merged
merged 3 commits into from
May 22, 2024

Conversation

BlackySoul
Copy link
Contributor

@BlackySoul BlackySoul commented May 16, 2024


  • Документация фичи

Описание

Иногда требуется отключить автоматический расчет наиболее удачного расположения

Изменения

Добавляем disablePlacementFlip, чтобы форсировать placement, отключая применение плагинов flipMiddleware и autoPlacementMiddleware

Copy link
Contributor

github-actions bot commented May 16, 2024

size-limit report 📦

Path Size
JS 362.97 KB (+0.09% 🔺)
JS (gzip) 111.13 KB (+0.08% 🔺)
JS (brotli) 91.48 KB (-0.01% 🔽)
JS import Div (tree shaking) 1.42 KB (0%)
CSS 275.39 KB (0%)
CSS (gzip) 35.9 KB (0%)
CSS (brotli) 29.07 KB (0%)

Copy link

codesandbox-ci bot commented May 16, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

github-actions bot commented May 16, 2024

e2e tests

Playwright Report

Copy link
Contributor

github-actions bot commented May 16, 2024

👀 Docs deployed

Commit 4ddc817

Copy link

codecov bot commented May 16, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 83.36%. Comparing base (ae5ca12) to head (4ddc817).
Report is 12 commits behind head on master.

Files Patch % Lines
.../floating/useFloatingMiddlewaresBootstrap/index.ts 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6922      +/-   ##
==========================================
+ Coverage   83.35%   83.36%   +0.01%     
==========================================
  Files         351      351              
  Lines       10469    10482      +13     
  Branches     3475     3482       +7     
==========================================
+ Hits         8726     8738      +12     
- Misses       1743     1744       +1     
Flag Coverage Δ
unittests 83.36% <90.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BlackySoul BlackySoul changed the title feat(Popover): add forcePlacement prop feat(Popover): add disablePlacementFlip prop May 17, 2024
@BlackySoul BlackySoul requested a review from inomdzhon May 21, 2024 15:44
Copy link
Contributor

@inomdzhon inomdzhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@inomdzhon inomdzhon merged commit 842d807 into master May 22, 2024
26 checks passed
@inomdzhon inomdzhon deleted the feat/6917/Popover_add_forced_placement branch May 22, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants