Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(DateInput): add docs clarification about disabled date #6913

Merged
merged 1 commit into from
May 21, 2024
Merged

fix(DateInput): add docs clarification about disabled date #6913

merged 1 commit into from
May 21, 2024

Conversation

BlackySoul
Copy link
Contributor

Описание

Пришли в чатик с вопросом о неработающем minDateTime. Причина была в одновременном применении disablePast и minDateTime.

Изменения

Добавляем в документацию пояснение порядка применения пропов.

@BlackySoul BlackySoul added this to the v6.1.0 milestone May 15, 2024
@BlackySoul BlackySoul self-assigned this May 15, 2024
@BlackySoul BlackySoul requested a review from a team as a code owner May 15, 2024 12:09
@github-actions github-actions bot added the patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча label May 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

size-limit report 📦

Path Size
JS 366.07 KB (0%)
JS (gzip) 112.34 KB (0%)
JS (brotli) 92.73 KB (0%)
JS import Div (tree shaking) 1.42 KB (0%)
CSS 273.88 KB (0%)
CSS (gzip) 35.6 KB (0%)
CSS (brotli) 28.85 KB (0%)

@github-actions GitHub Actions
Copy link
Contributor

e2e tests

Playwright Report

@github-actions GitHub Actions
Copy link
Contributor

👀 Docs deployed

Commit 54a9d12

mendrew
mendrew previously approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@mendrew mendrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💅

inomdzhon
inomdzhon previously approved these changes May 16, 2024
View reviewed changes
@BlackySoul BlackySoul dismissed stale reviews from inomdzhon and mendrew via 24e84f2 May 16, 2024 09:03
@BlackySoul BlackySoul force-pushed the blackysoul/dateinput_props_applying branch from 54a9d12 to 24e84f2 Compare May 16, 2024 09:03
@codesandbox-ci CodeSandbox CI
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@inomdzhon
Copy link
Contributor

image

🤔

@BlackySoul BlackySoul marked this pull request as draft May 16, 2024 11:53
@BlackySoul BlackySoul marked this pull request as ready for review May 16, 2024 11:53
@BlackySoul BlackySoul removed the patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча label May 16, 2024
@BlackySoul BlackySoul merged commit cf94740 into master May 21, 2024
1 check passed
@BlackySoul BlackySoul deleted the blackysoul/dateinput_props_applying branch May 21, 2024 04:43
@vkcom-publisher
Copy link
Contributor

✅ v6.1.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mendrew mendrew mendrew approved these changes

@inomdzhon inomdzhon inomdzhon approved these changes

Assignees

@BlackySoul BlackySoul

Labels
None yet
Projects
VKUI
Archived in project
Milestone
v6.1.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@BlackySoul @inomdzhon @vkcom-publisher @mendrew