feat(Textarea): support after prop
#6331
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eugpoloz
changed the title
after prop
size-limit report 📦
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 0deee5b:
|
e2e tests |
👀 Docs deployed
Commit 0deee5b |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6331 +/- ##
=======================================
Coverage 81.26% 81.26%
=======================================
Files 326 326
Lines 10108 10108
Branches 3397 3397
=======================================
Hits 8214 8214
Misses 1894 1894
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Надо бы сначала сходить к дизайну и попросить их отрисовать в дизайн-системе такой вариант х) Чтобы было понятно, с какими отступами разрулить такую ситуацию:
|
github-actions
bot
added
the
pr-needs-work
eugpoloz
added
no-stale
eugpoloz
force-pushed
the
eugpoloz/6307-Textarea-after
branch
from
76cdbee
to
0deee5b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание
Добавила поддержку
afterв Textarea.Изменения
Textareaотличается от обычных инпутов тем, что может меняться в размерах. Поэтомуafterспозиционирован так же, как кнопка копирования примера в блоке "Редактирование кода" в нашей текущей доке: абсолютно и по правому верхнему (block-start inline-end) краю.