Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Skeleton #5941

Merged
merged 11 commits into from
May 20, 2024
Merged

feat: add Skeleton #5941

merged 11 commits into from
May 20, 2024

Conversation

SevereCloud
Copy link
Contributor

@SevereCloud SevereCloud commented Oct 9, 2023 •
edited

  • Unit-тесты
  • e2e-тесты
  • Дизайн-ревью
  • Документация фичи

Описание

Добавляем скелетон

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2023 •
edited

size-limit report 📦

Path Size
JS 366.87 KB (+0.22% 🔺)
JS (gzip) 112.62 KB (+0.26% 🔺)
JS (brotli) 92.89 KB (+0.18% 🔺)
JS import Div (tree shaking) 1.42 KB (0%)
CSS 275.39 KB (+0.56% 🔺)
CSS (gzip) 35.9 KB (+0.84% 🔺)
CSS (brotli) 29.07 KB (+0.78% 🔺)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 9, 2023 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2023 •
edited

e2e tests

Playwright Report

@codecov
Copy link

codecov bot commented Oct 9, 2023 •
edited

Codecov Report

Attention: Patch coverage is 78.57143% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 83.34%. Comparing base (2816293) to head (a4d3092).

Files Patch % Lines
packages/vkui/src/components/Skeleton/Skeleton.tsx 78.57% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5941      +/-   ##
==========================================
- Coverage   83.35%   83.34%   -0.01%     
==========================================
  Files         351      352       +1     
  Lines       10469    10483      +14     
  Branches     3475     3480       +5     
==========================================
+ Hits         8726     8737      +11     
- Misses       1743     1746       +3
Flag Coverage Δ
unittests 83.34% <78.57%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2023 •
edited

👀 Docs deployed

Commit a4d3092

@SevereCloud SevereCloud added this to the v6 milestone Oct 9, 2023
@SevereCloud SevereCloud self-assigned this Oct 9, 2023
@SevereCloud SevereCloud marked this pull request as ready for review October 9, 2023 11:06
@SevereCloud SevereCloud requested a review from a team as a code owner October 9, 2023 11:06
mendrew
mendrew reviewed Oct 9, 2023
View reviewed changes
Copy link
Contributor

@mendrew mendrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

Единственное, что не очень нравится, это явная установка стиля для каждого скелетона через ref.

packages/vkui/src/components/Skeleton/Skeleton.tsx Outdated Show resolved Hide resolved
packages/vkui/src/components/Skeleton/Skeleton.tsx Outdated Show resolved Hide resolved
@SevereCloud SevereCloud added the no-stale Добавляет PR в исключения для автоматического закрытия label Oct 10, 2023
@SevereCloud SevereCloud marked this pull request as draft October 10, 2023 08:25
@SevereCloud SevereCloud removed this from the v6 milestone Oct 24, 2023
@SevereCloud SevereCloud removed their assignment Oct 24, 2023
@SevereCloud SevereCloud added this to the v6 milestone Oct 24, 2023
@SevereCloud SevereCloud self-assigned this Oct 24, 2023
@SevereCloud SevereCloud modified the milestones: v6, v6.1.0 Dec 21, 2023
@SevereCloud SevereCloud force-pushed the SevereCloud/feat/add-Skeleton branch from 92988ed to 66b979a Compare April 8, 2024 11:45
@SevereCloud SevereCloud marked this pull request as ready for review April 8, 2024 11:58
@SevereCloud SevereCloud force-pushed the SevereCloud/feat/add-Skeleton branch from 7c28357 to cb8dadb Compare April 16, 2024 13:20
mendrew
mendrew previously approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@mendrew mendrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 🔥 🔥

@BlackySoul
Copy link
Contributor

А мейби в дизайн наш это тоже унести?)

Вкусовщина, но вот эти белые проплешины меня прям триггерят 😄

2024-05-06.20.11.06.mov

mendrew
mendrew previously approved these changes May 13, 2024
View reviewed changes
@SevereCloud SevereCloud requested a review from mendrew May 16, 2024 11:03
inomdzhon
inomdzhon previously approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@inomdzhon inomdzhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

тайпчек упал

image

@SevereCloud SevereCloud force-pushed the SevereCloud/feat/add-Skeleton branch from b853dd1 to a4d3092 Compare May 20, 2024 09:09
mendrew
mendrew approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor

@mendrew mendrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Zaycevq
Zaycevq approved these changes May 20, 2024
View reviewed changes
Copy link

@Zaycevq Zaycevq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

@SevereCloud SevereCloud merged commit 072106e into master May 20, 2024
24 of 26 checks passed
@SevereCloud SevereCloud deleted the SevereCloud/feat/add-Skeleton branch May 20, 2024 13:06
@vkcom-publisher
Copy link
Contributor

✅ v6.1.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fedorov-xyz fedorov-xyz fedorov-xyz requested changes

@mendrew mendrew mendrew approved these changes

@inomdzhon inomdzhon inomdzhon approved these changes

@MrZillaGold MrZillaGold MrZillaGold approved these changes

@Zaycevq Zaycevq Zaycevq approved these changes

Assignees

@SevereCloud SevereCloud

Labels
no-stale Добавляет PR в исключения для автоматического закрытия
Projects
VKUI
Archived in project
Milestone
v6.1.0
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@SevereCloud @BlackySoul @vkcom-publisher @mendrew @inomdzhon @fedorov-xyz @MrZillaGold @Zaycevq